Use frozen string literal in actionpack/ #29933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
|
CI looks good except those flaky actioncable and sqlite tests that have been popping for the past week. |
|
@matthewd could you have a look? Thanks! |
bdewater
reviewed
Jul 29, 2017
| @@ -295,7 +297,7 @@ def log_error(exception) | |||
| return unless logger | |||
|
|
|||
| logger.fatal do | |||
| message = "\n#{exception.class} (#{exception.message}):\n" | |||
| message = "\n#{exception.class} (#{exception.message}):\n".dup | |||
There was a problem hiding this comment.
According to rubocop/rubocop#4586 dup is not the fastest way.
There was a problem hiding this comment.
@bdewater But that syntax is available from ruby 2.3 and above only, right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29655
Extends
Style/FrozenStringLiteralCommentrule toactionpack/.The commit is just
rubocop -aafter updating the Rubocop config.Note: like in #29897, I had to exclude
.builderand.rubytest fixtures because using frozen string literal there leads to warnings:Likely because Builder templates are eval'ed.
Related to:
#29728
#29819
#29732
#29896