Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frozen string literal in actionview/ #29897

Merged
merged 1 commit into from Jul 24, 2017
Merged

Use frozen string literal in actionview/ #29897

merged 1 commit into from Jul 24, 2017

Conversation

kirs
Copy link
Member

@kirs kirs commented Jul 23, 2017

Follow-up to #29655

Extends Style/FrozenStringLiteralComment Rubocop rule to actionview/.

The commit is just rubocop -a after changing the Rubocop rule.

Similar to:
#29728
#29819
#29732
#29896

@rails-bot
Copy link

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

@kirs
Copy link
Member Author

kirs commented Jul 23, 2017

Note: I had to exclude .builder fixtures because using frozen string literal there leads to warnings:

actionview/test/fixtures/actionpack/test/non_erb_block_content_for.builder:1: warning: `frozen_string_literal' is ignored after any tokens
actionview/test/fixtures/actionpack/test/hello.builder:1: warning: `frozen_string_literal' is ignored after any tokens
actionview/test/fixtures/actionpack/layouts/builder.builder:1: warning: `frozen_string_literal' is ignored after any tokens
actionview/test/fixtures/actionpack/test/hello_world_container.builder:1: warning: `frozen_string_literal' is ignored after any tokens
actionview/test/fixtures/actionpack/test/_hello.builder:1: warning: `frozen_string_literal' is ignored after any tokens
actionview/test/fixtures/actionpack/test/hello_world_from_rxml.builder:1: warning: `frozen_string_literal' is ignored after any tokens

Likely because Builder templates are eval'ed.

@kirs
Copy link
Member Author

kirs commented Jul 23, 2017

#29900 should fix the test failures.

@kirs
Copy link
Member Author

kirs commented Jul 24, 2017

The build looks good, besides flaky actioncable tests.

@kirs
Copy link
Member Author

kirs commented Jul 24, 2017

cc @sgrif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants