Improve callback examples in Active Job guide #30060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advice for symbol/block form is taken from the Active Record guides.
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
lugray
reviewed
Aug 4, 2017
guides/source/active_job_basics.md
Outdated
|
|
||
| ```ruby | ||
| class ApplicationJob | ||
| before_enqueue do |job| |
There was a problem hiding this comment.
Given "so short that it fits in a single line" I'd recommend:
before_enqueue { |job| $statsd.increment "#{job.name.underscore}.enqueue" }There was a problem hiding this comment.
Thanks 👍 I've changed it.
bdewater
force-pushed
the
aj-callback-docs
branch
from
e6d2d33
to
2f96912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the AJ guides to be a bit light on the subject and noticed the examples given contradicted the advice for AR callbacks when to register callbacks with a method or a block.