Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator example code [ci skip] #30186

Merged
merged 1 commit into from Aug 11, 2017

Conversation

yhirano55
Copy link
Contributor

@yhirano55 yhirano55 commented Aug 10, 2017

Summary

Fix example codes for generators guide.

  1. On lib method, we have to return string inside block.
  2. On rakefile method, we have to define tasks. When it given "hello, there", then it'll raises

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@robin850 robin850 merged commit b4eaf57 into rails:master Aug 11, 2017
@robin850
Copy link
Member

Thanks ! :-)

@yhirano55 yhirano55 deleted the fix_generator_example_code branch August 11, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants