Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugging rails application [ci skip] #30249

Merged

Conversation

yhirano55
Copy link
Contributor

Summary

  • The example code is outdated. So I've modified coding style:
    1. Use strong parameter.
    2. Use notice option instead of flash[:notice].
  • Fix indentation.

@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@@ -162,16 +162,15 @@ class ArticlesController < ApplicationController
# ...

def create
@article = Article.new(params[:article])
@article = Article.new(article_params)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

article_params is not defined for us to use it. Lets defined that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipulnsward Thanks for the comment. I've defined article_params.

@yhirano55 yhirano55 force-pushed the fix_debugging_rails_application_guide branch from 7242fcd to b44b393 Compare August 14, 2017 13:26
@vipulnsward vipulnsward merged commit c443417 into rails:master Aug 14, 2017
@yhirano55 yhirano55 deleted the fix_debugging_rails_application_guide branch August 14, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants