Change namespace of Active Storage rake task

[koic]

Summary

The following is a display of the result of rake -T using the Active Storage application.

% bin/rake -T
rake about                              # List versions of all Rails frameworks and the environment
rake active_storage:install:migrations  # Copy migrations from active_storage to application
rake activestorage:install              # Copy over the migration needed to the application
rake app:template                       # Applies the template supplied by LOCATION=(/path/to/template) or URL

(snip)

The namespace of active_storage:install:migrations and activestorage:install are different. This PR unifies the namespace of Active Storage rake task to active_storage.

The namespace of active_storage:install:migrations depends on Engine#railtie_name.

rails/railties/lib/rails/engine.rb

Lines 627 to 630 in 0789d09

	namespace railtie_name do
	namespace :install do
	desc "Copy migrations from #{railtie_name} to application"
	task :migrations do

So I think that the change target is namespace defined by activestorage.rake.

[rails-bot]

r? @matthewd

(@rails-bot has picked a reviewer for you, use r? to override)

[matthewd]

This feels to me like the sort of place we might deliberately choose the no-underscore spelling. They should be consistent... I just wonder which one we'd rather standardize on.

@dhh?

[dhh]

This problem should be going away shortly as the rake task is getting nixed in favor of a better way to install this migration. In general, I don't think these tasks should be prefixed by their framework. It's db:create, not active_record:db:create. And even if we did keep this rake task, it should be something like blob:migrations.

[sikachu]

Yeah, I was thinking that ASt rake tasks could just be under storage prefix (such as, say, storage:clear_tmp). I think it's okay for activestorage:install to contain activestorage prefix though.

By the way, I think the correct fix might actually be making active_storage:install:migrations not showing up when do rake -T because it looks like we don't want user to call active_storage:install:migrations directly and call activestorage:install wrapper task instead.

[kamipo]

Ah, I agree with active_storage:install:migrations should not be shown and active_storage is not preferable prefix.

[koic]

Thank you for discussion.

I'd like to open a new PR with the following changes.

• Rename active_storage:install task to blob:migrations task
• Don't display active_storage:install:migrations task on rake -T

What do you think?

[koic]

I opened a PR #30378 so that it would proceed on a code base.

[dhh]

@koic We're going to nix the need for an explicit rake task for this. At least for new apps. @sgrif is investigating what to do instead.

[koic]

@dhh I got it. Thank you for sharing your information with me.