[patch] Asset helpers should understand scheme-relative URLs #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge is_uri? and is_scheme_independent_uri?. The former should include a check for the latter. Need not be a separate method call. "//g.com" is an uri. |
|
Thanks for the feedback. I've made the change. |
arunagw
pushed a commit
to arunagw/rails
that referenced
this pull request
Apr 26, 2011
[patch] Asset helpers should understand scheme-relative URLs
|
Applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please see the lighthouse ticket I submitted for details on this patch request:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6748
A Rails contributer, @sferik, suggested I also submit a pull request.
Does this change look OK? Your time and feedback are appreciated.
Thanks,
Chad