Correctly override image_path in sprockets rails_helper #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spastorino
added a commit
that referenced
this pull request
Sep 26, 2011
Correctly override image_path in sprockets rails_helper
spastorino
added a commit
that referenced
this pull request
Sep 26, 2011
Correctly override image_path in sprockets rails_helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit 0cb84f1 broke the
image_pathhelper when the assets pipeline is enabled.Instead of
/assetsit would prepend/imageswhenimage_path()was used. This is due to the wayimage_pathandpath_to_imageare aliased to each other inasset_tag_helperThis patch fixes the
image_pathhelper.I am perplexed as to why in
sprockets_helper_textwhat is tested isasset_path, an undocumented method, and notimage_pathwhich is the publish API (along withvideo_path,audio_pathand all its siblings)Shouldn't the test be refactored somehow?