Don't include Active Storage migrations in new apps #31534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rails#31315 for full discussion
When a user tries to create a new attachment or blog and the matching table is missing from the database (`active_storage_attachments` and `active_storage_blobs` by default), an informative error is displayed that invites users to run the `active_storage:install` task.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 10, 2018
Remove `AppGeneratorTest#test_active_storage_install`. The test is added by 67db41a, since rails#31534 this test doesn't test anything. Remove redundant assertions in `SharedGeneratorTests`. These assertions is added by 4a835aa. Follows 67db41a, rails#31534.
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Mar 12, 2019
…does not exist - This is similar to the work done in rails#31534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the complete discussion see #31315
Closes #31315
This is an alternative implementation as suggested by @kaspth in
#31315 (comment)
@kaspth -- Is this what you intended? Am I missing anything? What kind of tests should I add?
For the template files, I have copied/pasted https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb and then added the
ifstatement.