Clean up railties tests #31667
Merged
Clean up railties tests #31667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Please squash your commits into a single commit? |
Remove `AppGeneratorTest#test_active_storage_install`. The test is added by 67db41a, since rails#31534 this test doesn't test anything. Remove redundant assertions in `SharedGeneratorTests`. These assertions is added by 4a835aa. Follows 67db41a, rails#31534.
bogdanvlviv
force-pushed
the
clean-up-railties-tests
branch
from
ea45b98
to
b6ed9a7
Compare
|
Yes. I just squashed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AppGeneratorTest#test_active_storage_install
The test is added by 67db41a,
since Don't include Active Storage migrations in new apps #31534 this test doesn't test anything
Remove redundant assertions in SharedGeneratorTests
These assertions is added by 4a835aa.
Follows 67db41a, Don't include Active Storage migrations in new apps #31534
r? @y-yagi