Fix locale_selector JS bug in ActionMailer Preview #31750
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
Thanks. But, if |
| @@ -95,14 +95,16 @@ | |||
| </dd> | |||
| <% end %> | |||
|
|
|||
| <dt>Format:</dt> | |||
There was a problem hiding this comment.
Always shows Format in order to detect which mime_type is selected for @email.
|
@y-yagi Thank you for review. I coped with the case you pointed out. Can you review it again please? |
| <dd> | ||
| <select id="part" onchange="refreshBody();"> | ||
| <option <%= request.format == Mime[:html] ? 'selected' : '' %> value="<%= part_query('text/html') %>">View as HTML email</option> | ||
| <option <%= request.format == Mime[:text] ? 'selected' : '' %> value="<%= part_query('text/plain') %>">View as plain-text email</option> | ||
| </select> | ||
| </dd> | ||
| <% else %> | ||
| <dd id="mime_type" data-mime_type="<%= part_query(@email.mime_type) %>"><%= @email.mime_type == 'text/html' ? 'HTML email' : 'plain-text email' %></dd> |
There was a problem hiding this comment.
Since we often use a hyphen for data attributes, can you change it to data-mime-type?
|
I added a minor comment. Other than that it looks good to me. After fix that, please squash your commits into a single commit. |
morygonzalez
force-pushed
the
consider-locale_selector-missing
branch
2 times, most recently
from
a58d4c8
to
be54f92
Compare
|
Applied @y-yagi's change request and squashed all commits. |
| iframe.contentWindow.location = '?' + part_param + '&' + locale_param; | ||
| var part_param = part_select ? | ||
| part_select.options[part_select.selectedIndex].value : | ||
| document.querySelector('#mime_type').dataset.mime-type; |
There was a problem hiding this comment.
dataset.mime-type must be dataset.mimeType.
morygonzalez
force-pushed
the
consider-locale_selector-missing
branch
from
be54f92
to
77453cf
Compare
|
Fixed data attribute name typo. Confirmed that it works.
|
|
@morygonzalez Thanks!! |
Summary
Fix bug arise from the Pull Request #3159 .
What I did
In order to referring undefined variable, check if
<select id="locale">exists before refreshing ActionMailer Preview body.@y-yagi Please review this.