Add locale selector to email preview #31596
Conversation
- Add set_locale to detect suitable locale - Make feature compatible with Rails 5.x
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| var part_select = document.querySelector('select#part'); | ||
| var locale_select = document.querySelector('select#locale'); | ||
| var part_param = part_select.options[part_select.selectedIndex].value; | ||
| var locale_param = locale_select.options[locale_select.selectedIndex].value; |
There was a problem hiding this comment.
locale_select only appears in I18n.available_locales.count > 1.
So if users have only one locale, this code will occur error.
There was a problem hiding this comment.
Oh my bad 😱 I will fix this.
Summary
This Pull Request make it possible to select location on ActionMailer Preview. Just like below.
This is a rework of #19923. #19923 was almost done, but had not been merged and now it gets conflict against master.
What I did:
?locale=<locale_name>if locale were changed.