Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale selector to email preview #31596

Merged

Conversation

Projects
None yet
6 participants
@morygonzalez
Copy link
Contributor

morygonzalez commented Dec 30, 2017

Summary

This Pull Request make it possible to select location on ActionMailer Preview. Just like below.

actionmailer-preview-locale-selection

This is a rework of #19923. #19923 was almost done, but had not been merged and now it gets conflict against master.

What I did:

  • Add set_locale to detect suitable locale ( #19923's author @plus3x's work)
  • Fix conflicts.
  • Append query parameter ?locale=<locale_name> if locale were changed.
  • Update JavaScript function to refresh format and locale of mail preview.
  • Add test case for the feature.
Add locale selector to email preview
- Add set_locale to detect suitable locale
- Make feature compatible with Rails 5.x
@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Dec 30, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo added the actionmailer label Jan 11, 2018

@rafaelfranca rafaelfranca merged commit 5fe603a into rails:master Jan 18, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
var part_select = document.querySelector('select#part');
var locale_select = document.querySelector('select#locale');
var part_param = part_select.options[part_select.selectedIndex].value;
var locale_param = locale_select.options[locale_select.selectedIndex].value;

This comment has been minimized.

Copy link
@y-yagi

y-yagi Jan 19, 2018

Member

locale_select only appears in I18n.available_locales.count > 1.
So if users have only one locale, this code will occur error.

This comment has been minimized.

Copy link
@morygonzalez

morygonzalez Jan 19, 2018

Author Contributor

Oh my bad 😱 I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.