Improve css in guide #32401
Merged
Improve css in guide #32401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* .clearfix is overridden. * .clear is not currently used. * #extraCol is not currently used. * table th, table td are overridden. Merged them. * Removed needless comment lines which are added on rails#6475
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
|
@yhirano55 thanks for the PR. Can you provide screenshots of before/after with your changes? |
yhirano55
commented
Apr 19, 2018
| @@ -70,7 +70,7 @@ table { | |||
| } | |||
|
|
|||
| table th, table td { | |||
| padding: 0.25em 1em; | |||
There was a problem hiding this comment.
Overriden by this line, so changed padding values.
|
@eileencodes Thank you so much for your comment. I've not changed any UI (Fix needless styles or properties). But to be safe, I provide screenshots about before and after: Before
After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
text-align: leftis defined on reset.css )