Make confirm dialog overridable in rails_ujs

[mathieumahe]

I would like to override the default confirm dialog in rails_ujs to add different possibilities (a nice modal instead of the default box, add a prompt before destroying super-sensitive data like github does with repos, etc.)

One possibility would be to reference the method as Rails.handleConfirm instead of using a variable here :

rails/actionview/app/assets/javascripts/rails-ujs/start.coffee

Line 45 in 896ee2b

delegate document, Rails.buttonClickSelector, 'click', handleConfirm

Like that, we could override it between the import and the call to Rails.start()

Even better, if we could extract the code of the confirm call

rails/actionview/app/assets/javascripts/rails-ujs/features/confirm.coffee

Line 23 in 896ee2b

try answer = confirm(message)

in a method accessible from outside the scope of the file, we could be able to redefine only the code we need.

What do you think ?

Thanks !

[y-yagi]

This is being addressed with #29965. Please wait for it to be merged. Thanks.

[mathieumahe]

The pull request doesn't look very active.

Should I create a new one following Rafael's advices ?

[y-yagi]

Go ahead 👍