Deprecate support for using HOST environment to specify server IP
#32540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
Apr 12, 2018
matthewd
reviewed
Apr 12, 2018
| ActiveSupport::Deprecation.warn(<<-MSG.squish) | ||
| Using the `HOST` environment to specify the IP is deprecated and will be removed in Rails 6.1. | ||
| Please use `BINDING` environment instead. | ||
| MSG |
There was a problem hiding this comment.
For a smoother upgrade path, I think this should only complain if BINDING is not set
There was a problem hiding this comment.
Good call. I fixed, thanks!
At SuSE, `$HOST` is set by default and is equal to `$HOSTNAME`. https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_adm_variables.html Therefore, by default, it binds to hostname instead of `localhost`. This seems not to be appropriate as default behavior. In order to avoid the name of the environment variable being used, I changed the environment variable from `HOST` to `BINDING`. Fixes rails#29516.
pudiva
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Jul 9, 2020
Rails 6 deprecated the HOST variable in favour of BINDING See: rails/rails#32540
pudiva
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Jul 9, 2020
Rails 6 deprecated the HOST variable in favour of BINDING See: rails/rails#32540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At SuSE,
$HOSTis set by default and is equal to$HOSTNAME.https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_adm_variables.html
Therefore, by default, it binds to hostname instead of
localhost. This seems not to be appropriate as default behavior.In order to avoid the name of the environment variable being used, changed the environment variable from
HOSTtoBINDING.Fixes #29516.