Remove user-specified delimiter from start when no area code is present (in number_to_phone) #3314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, specifying a delimiter to number_to_phone when no area code is present would result in the delimiter at the start of the resulting phone number:
For example:
number_to_phone("5550000", :delimiter => ".")
would become: .555.0000
but should be: 555.0000
(notice, the leading '.')
This pull request fixes that. All existing tests pass and new test added.