Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport documentation fixes #33174

Merged
merged 1 commit into from Sep 13, 2018
Merged

Backport documentation fixes #33174

merged 1 commit into from Sep 13, 2018

Conversation

thomasdziedzic-pd
Copy link
Contributor

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-2-stable. Please double check that you specified the right target!

Copy link
Contributor

@utilum utilum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original motivation for #33170 is addressed by this patch. These config vars are in use in 5.2

@utilum
Copy link
Contributor

utilum commented Jun 20, 2018

#33172 was also merged into 5-2-stable. So only the second of the two commits here is still needed.

@thomasdziedzic-pd
Copy link
Contributor Author

Updated the commits to reflect the backport being added.

Copy link
Contributor

@bogdanvlviv bogdanvlviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should be backported to 5-2-stable since
action_dispatch.use_authenticated_cookie_encryption is true by default https://github.com/rails/rails/blob/5-2-stable/railties/lib/rails/application/configuration.rb#L102

Related to c8a22bb.

Thank you for the PR!

@rafaelfranca rafaelfranca merged commit 41d5458 into rails:5-2-stable Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants