Avoid extra scoping in delegating to klass methods in the scope block
#33394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rails#29301, delegating to klass methods in the `scope` block would cause extra scoping by the receiver itself. The extra scoping would always override intermediate scoping like `unscoped` and caused the regression rails#33387. To keep the original scoping behavior, should avoid the extra scoping in the `scope` block. Fixes rails#33387.
eileencodes
added a commit
that referenced
this pull request
Jul 19, 2018
Avoid extra scoping in delegating to klass methods in the `scope` block
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Nov 29, 2018
Follow up rails#33394. rails#33394 only fixes the case of scoping with klass methods in the scope block which invokes `klass.all`. Query methods in the scope block also need to invoke `klass.all` to be affected by the scoping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #29301, delegating to klass methods in the
scopeblock wouldcause extra scoping by the receiver itself. The extra scoping would
always override intermediate scoping like
unscopedand caused theregression #33387. To keep the original scoping behavior, should avoid
the extra scoping in the
scopeblock.Fixes #33387.