Call build when extend with nested attributes defined #33454
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
al3rez
force-pushed
the
extend-affects-nested-attributes
branch
2 times, most recently
from
c37ffe8
to
2c533d8
Compare
|
@schneems Hi buddy would you please check out this PR? |
|
Dug a bit and the change make sense |
|
Can you give credit to the author (#33389 https://gist.github.com/martinsp/92d17373699df5c16b0f00bbb1b174e3#file-association-extension-fixed-rb-L93) with http://contributors.rubyonrails.org/faq#credit-several-people? |
What? From now on when `accepts_nested_attributes_for` defined and `extend` option added the overwritten `build` method being called. [Alireza Bashiri, Martins Polakovs]
al3rez
force-pushed
the
extend-affects-nested-attributes
branch
from
2c533d8
to
dc16cdd
Compare
|
@kamipo done. |
|
Thanks! |
|
@schneems Would it be possible to get this fix backported into 5-2-stable? |
Summary
What?
Fixes #33389 - From now on when
accepts_nested_attributes_fordefined andextendoptionadded the overwritten
buildmethod being called.