Fixtures refactor #34076
Fixtures refactor #34076
Conversation
gmcgibbon
force-pushed
the
fixtures_refactor
branch
3 times, most recently
from
525a329
to
72d88f8
Compare
There was a problem hiding this comment.
Awesome @gmcgibbon ! I have left you two inline comments, please tell me what you think about them.
| end | ||
|
|
||
| def reflection_class | ||
| @refelction_class ||= if @row.include?(model_metadata.inheritance_column_name) |
There was a problem hiding this comment.
Little typo here @refelction_class -> @reflection_class
There was a problem hiding this comment.
🤦♂️ Thanks, I'll fix that!
| fixture_set_names = Array(fixture_set_names).map(&:to_s) | ||
| class_names = ClassCache.new class_names, config | ||
|
|
||
| # FIXME: Apparently JK uses this. |
There was a problem hiding this comment.
This is not in the scope of this PR, but maybe we can get rid of this comment, it has already been here for many years...
There was a problem hiding this comment.
Yeah, I was meaning to comment on this as well. We will address it after some feedback from the core team. 👍
There was a problem hiding this comment.
JK also became JD in the intervening years 😄 — Now I'm curious @jeremy, are you still using it?
There was a problem hiding this comment.
Let's leave it. Normally I'd say a test is sufficient but I know this comment has stopped me from messing with this line before and I'd rather not break Basecamp's fixtures. Also I get a good laugh from it whenever I see it. 😉
There was a problem hiding this comment.
Asking here out of curiosity and behaviour I discovered today around this method
- What is JK or JD here?
connection = block_given? ? yield : ActiveRecord::Base.connectionaccepts a connection as a block tocreate_fixtureswhich appratenly fixed an issue I was having for my project's test suite where I was able to create fixtures for different shards in mytest_helper.rb, purely because of this line. Rougly I ended up doing something like this,
# worked
ActiveRecord::FixtureSet.create_fixtures('test/fixtures', 'posts') { ActiveRecord::Base.connecting_to(shard: :a) }For some reason,
# This did not work
ActiveRecord::Base.connected_to(shard: :a) { ActiveRecord::FixtureSet.create_fixtures('test/fixtures', 'posts') }@eileencodes any thoughts on the behaviour?
gmcgibbon
force-pushed
the
fixtures_refactor
branch
3 times, most recently
from
a1c0c2a
to
6371853
Compare
…to FixtureSet::TableRows
gmcgibbon
force-pushed
the
fixtures_refactor
branch
from
6371853
to
cfeabbf
Compare
There was a problem hiding this comment.
Independently of JK/JD I'm +1 on this PR 😉 Thanks @gmcgibbon !
| end | ||
|
|
||
| def instantiate_fixtures(object, fixture_set, load_instances = true) | ||
| return unless load_instances |
Summary
ActiveRecord::FixtureSetclass cleanup.Introduce
FixtureSet::ModelMetadata,FixtureSet::TableRows, andFixtureSet::TableRowfor generating insertion hashes for fixtures.Encapsulate
FixtureSet.create_fixturesreading and insertion sectionsinto separate private methods.
Most of this is just trying to break the process of generating and inserting fixture hashes into smaller pieces.
r? @rafaelfranca
/cc @eileencodes