Remove bundler warnings from bin/setup output #34101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
fix_bundler_1_16_6_test_failures
branch
from
0abc7d1
to
691cdfb
Compare
rafaelfranca
reviewed
Oct 5, 2018
| @@ -43,18 +43,19 @@ def test_bin_setup_output | |||
|
|
|||
| # Ignore line that's only output by Bundler < 1.14 | |||
| output.sub!(/^Resolving dependencies\.\.\.\n/, "") | |||
| output.gsub!(/^The dependency .* will be unused .*\.\n/, "") | |||
There was a problem hiding this comment.
Maybe we could add a different comment here? The comment above make it should like this line is for bundler < 1.14
There was a problem hiding this comment.
Ah, good catch. I'll fix it!
gmcgibbon
force-pushed
the
fix_bundler_1_16_6_test_failures
branch
from
691cdfb
to
b596346
Compare
kamipo
pushed a commit
that referenced
this pull request
Oct 7, 2018
…ures Remove bundler warnings from bin/setup output
y-yagi
pushed a commit
that referenced
this pull request
Oct 12, 2018
…ures Remove bundler warnings from bin/setup output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing
bin/setuprailties test onbundler-1.16.6.r? @rafaelfranca