Clarify i18n load paths gotcha #34241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guides/source/i18n.md
Outdated
| @@ -135,6 +135,8 @@ I18n.available_locales = [:en, :pt] | |||
| I18n.default_locale = :pt | |||
| ``` | |||
|
|
|||
| Note that appending directly to `I18n.load_paths` instead of the application configured i18n will _not_ override translations from external gems. | |||
There was a problem hiding this comment.
I'm Spanish and I don't speak English natively, but I would say this reads better to me:
Suggested change
| Note that appending directly to `I18n.load_paths` instead of the application configured i18n will _not_ override translations from external gems. | |
| Note that appending directly to `I18n.load_paths` instead of to the application's configured i18n will _not_ override translations from external gems. |
There was a problem hiding this comment.
Sure, I'll use that. I don't want this change to be multiple commits, so I'll just give you credit in the commit message for the contributors app to pick up on instead.
There was a problem hiding this comment.
Thanks @gmcgibbon !
Sadly credit went to the wrong place, it went here -> Alberto Almagro Sotelo but my commits are really here -> Alberto Almagro.
How can we fix that?
Clarify `I18n.load_paths` vs `Rails.application.config.i18n.load_paths` behaviour. [Gannon McGibbon + Alberto Almagro Sotelo]
gmcgibbon
force-pushed
the
clarify_i18n_load_paths_gotcha
branch
from
650a9cb
to
5c62bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29365.
Remove unnecessary
#to_sin directory glob example code and adds a note about overriding translations from external gems.r? @rafaelfranca