Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Upgrading from Old Versions" from Asset Pipeline Guide [skip ci] #34261

Conversation

matildasmeds
Copy link
Contributor

@matildasmeds matildasmeds commented Oct 19, 2018

I would remove the chapter "Upgrading from Old Versions" from Asset Pipeline Guide altogether.

  • Information on how to upgrade Rails 2.x/3.2 does not seem relevant for current Rails version.
  • Also, all configuration changes mentioned are already included in Upgrading Ruby on Rails Guide,

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

* How to upgrade Rails 2.x/3.2 not relevant for this Guide
* All configuration changes are already included in Upgrading Ruby on Rails Guide
@matildasmeds matildasmeds force-pushed the guides_remove_upgrade_section_from_asset_pipeline_guide branch from 0105c6e to 317f465 Compare October 19, 2018 16:28
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. 👍 These upgrade docs seem primarily geared toward upgrading Rails 3 -> Rails 4.

@kamipo kamipo merged commit 802f374 into rails:master Oct 23, 2018
@kamipo
Copy link
Member

kamipo commented Oct 23, 2018

Thanks!

@matildasmeds matildasmeds deleted the guides_remove_upgrade_section_from_asset_pipeline_guide branch October 23, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants