Restore HWIA support to AJ::Arguments.deserialize #34351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
active_job_hwia_support
branch
from
a48196f
to
d3935cc
Compare
jeremy
reviewed
Oct 30, 2018
| @@ -147,7 +147,9 @@ def serialize_hash_key(key) | |||
| end | |||
|
|
|||
| def transform_symbol_keys(hash, symbol_keys) | |||
| hash.transform_keys do |key| | |||
| # NOTE: #transform_keys doesn't play well with | |||
| # HashWithIndifferentAccess hashes so we call #to_h here. | |||
There was a problem hiding this comment.
Can we be specific about the issue here?
There was a problem hiding this comment.
Yes, I will rewrite my comment.
| assert_equal( | ||
| { a: 1 }, | ||
| ActiveJob::Arguments.deserialize([indifferent_access_symbol_key]).first | ||
| ) |
Restore HashWithIndifferentAccess support to ActiveJob::Arguments.deserialize.
gmcgibbon
force-pushed
the
active_job_hwia_support
branch
from
d3935cc
to
676f680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #34262.
Restores
HashWithIndifferentAccesssupport toActiveJob::Arguments.deserialize.