Clarify the validation of present associations #34415
Conversation
I think that it is not clear what means that _an association is present_. Add that it is checking that the foreign key is not empty and that the referenced object exists to clarify it.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
@rails-bot how are you adding the labels and assigning someone to the PR? 😮 |
|
@Ana06 Thanks for contributing! Regarding rails bot: we use https://github.com/rails/rails-bot to assign a core member to review new PRs and we use https://github.com/rails/rails-probot + https://github.com/rails/rails/blob/master/.github/autolabeler.yml to automatically label PRs based on files edited. |
Thanks for the info! I really want to stop adding labels manually 😉 |
Based on some code I review today and in some questions/answers in StackOverflow, I think that it is not clear what means that an association is present. Add that it is checking that the foreign key is not empty and that the referenced object exists to clarify it.