Fix: Arel now emits a single pair of parens for UNION and UNION ALL #34437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
mysql has a great implementation to suppress multiple parens for union sql statements. This moves that functionality to the generic implementation This also introduces that functionality for UNION ALL
kbrock
force-pushed
the
union_all_paren
branch
from
d2c7b1c
to
63dd8d8
Compare
|
Thank you. Merged in 3dea7f0 |
rafaelfranca
added a commit
that referenced
this pull request
Nov 13, 2018
Fix: Arel now emits a single pair of parens for UNION and UNION ALL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple union all statement generates extra parens. This is not valid SQL and causes sqlite to throw an error (and possibly others).
Mysql has a great implementation to suppress multiple parens for
UNIONsql statements.This PR shares the
UNIONimplementation withUNION ALLand also shares the implementationwith the other database implementations.
This PR is moved from rails/arel#510 - which was addressing 4 issues over there.
Thanks all