Use direction instead of rtl flag #34507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
approved these changes
Nov 22, 2018
|
Does |
|
Not that I can see in the code. I think only |
|
I just checked locally; it doesn't. @albertoalmagro can you fix the syntax on your commit message? Thanks! |
Improve readability by using `direction` as CSS does. More info: https://developer.mozilla.org/en-US/docs/Web/CSS/direction Continues: #34486 [Alberto Almagro + Ufuk Kayserilioglu]
|
Done @gmcgibbon @rafaelfranca ! I've written it now as Thanks for checking it 👏 |
|
This was not a doc change but since it is not related to production code it was fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch improves readability by using
directioninstead ofrtlflag, as CSS does.I have also took the chance to:
.to_symwhen getting direction'senv_valueas it could be a String.FileUtils.rmasFileUtils.mvalready overwrites the assets if it existsOther Information
Continues: #34486
Gives credit to @paracycle
r? @rafaelfranca