Do nothing when the same block is included again #34553
Conversation
mjtko
force-pushed
the
fix/issue-14802
branch
from
8d1d1fb
to
0fce55e
Compare
|
|
Can you squash your commits? |
|
@rafaelfranca: yup, was just going to wait until they were all done first, but can do that now, np. |
mjtko
force-pushed
the
fix/issue-14802
branch
from
b01c9f6
to
68b6fef
Compare
|
Is the first commit necessary? |
|
No, I just wanted to ensure the original author of the patch, @razum2um, received sufficient credit. |
|
We usually give him credit in the commit message for the rails contributors app to pickup on. You can do |
If the same block is included multiple times, we no longer raise an exception or overwrite the included block instance variable. Fixes rails#14802. [Mark J. Titorenko + Vlad Bokov]
mjtko
force-pushed
the
fix/issue-14802
branch
from
68b6fef
to
8212dfc
Compare
|
Ok, thanks for the example! Squashed and modified accordingly. 😄 |
Do nothing when the same block is included again
|
could you please tell me, how should I learn what Rails release has this fix? |
|
@mjtko appreciate the credit, thanks 👍 |
…cument migrations For compatibility issues with Rails version >= 4.1 and < 5.2.3 we have to avoid to load more than once the Rails concerns rails/rails#34553
…cument migrations For compatibility issues with Rails version >= 4.1 and < 5.2.3 we have to avoid to load more than once the Rails concerns rails/rails#34553
…cument migrations For compatibility issues with Rails version >= 4.1 and < 5.2.3 we have to avoid to load more than once the Rails concerns rails/rails#34553
…cument migrations For compatibility issues with Rails version >= 4.1 and < 5.2.3 we have to avoid to load more than once the Rails concerns rails/rails#34553
If the same block is included multiple times, we no longer raise an exception or overwrite the included block instance variable.
Fixes #14802.