Allow DateTime comparison to Infinity/-Infinity. #3457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-1 |
|
damn it mike |
| @@ -127,6 +127,10 @@ class DateTime | |||
|
|
|||
| # Layers additional behavior on DateTime#<=> so that Time and ActiveSupport::TimeWithZone instances can be compared with a DateTime | |||
| def <=>(other) | |||
| super other.to_datetime | |||
| if other.respond_to?(:infinite?) and other.infinite? != 0 | |||
| -other.infinite? | |||
There was a problem hiding this comment.
if self is also an infinite you should check for equality and relative signage with other
There was a problem hiding this comment.
DateTime can't be an infinite, I believe. So self could never be an infinite.
|
maybe mike meant -∞ :). I added a comment and test cases to your pull request to cover equality and signage comparisons if both operands are a flavor of infinite. |
|
Thanks! I'll make those changes soon. |
|
I added the missing test cases. |
|
Is this still an issue? |
|
Yes. |
|
cc @tenderlove |
ghost
assigned 
|
This will need a big rebase if it's ever to be included. |
This was referenced Nov 11, 2012
|
@joevandyk ping! any interest in keeping this current? |
|
this isn't in there yet? :) i'll look at it. |
|
Fixed by #7350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of the fixes in #544 -- @tenderlove let ActiveRecord support Infinite timestamps, but you can't compare them to other DateTime values. This commit fixes that.