Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parallel testing guide [ci skip] #34596

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

bogdanvlviv
Copy link
Contributor

@bogdanvlviv bogdanvlviv commented Dec 2, 2018

  • Fix formatting
  • Don't repeat "Active Record automatically handles creating and migrating a new database for each worker to use."
  • Tell that AR loads the schema to a database for each process(Related to Make parallel testing db faster #33479)
  • Clarify that parallelize_teardown is executed for each process

@rails-bot rails-bot bot added the docs label Dec 2, 2018
@bogdanvlviv bogdanvlviv force-pushed the imporve-parallel-testing-guide branch 2 times, most recently from d925280 to 6b89006 Compare December 2, 2018 21:10
guides/source/testing.md Outdated Show resolved Hide resolved
- Fix formatting
- Don't repeat "Active Record automatically handles creating and migrating a new
  database for each worker to use."
- Tell that AR loads the schema to a database for each process(Related to rails#33479)
- Clarify that `parallelize_teardown` is executed for each process
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmcgibbon gmcgibbon merged commit 6ca6478 into rails:master Dec 3, 2018
@bogdanvlviv bogdanvlviv deleted the imporve-parallel-testing-guide branch December 4, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants