Colorize the unpermitted params log message #34617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This small change simply colorizes the unpermitted params warning/error log output to make it easier for scanning and identifying issues with strong params. I've been helping out some junior/beginner engineers with rails and more than a few times they've run into issues where they're just overlooking the log message. Not ashamed to say that this still gets me every once in a while, mostly because I feel like I've scanned the log and I don't see the message, so I go looking elsewhere.
It seems like moving the default to
:raise
instead of:log
is probably a good idea, but regardless if we'd raise an error, it seems like colorizing the log message makes sense as a parallel.