Fix join table column quoting with SQLite. #34626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Dec 5, 2018
| @@ -13,7 +13,7 @@ def quote_table_name_for_assignment(table, attr) | |||
| end | |||
|
|
|||
| def quote_column_name(name) | |||
| @quoted_column_names[name] ||= %Q("#{super.gsub('"', '""')}") | |||
| @quoted_column_names[name] ||= %Q("#{super.gsub('"', '""').gsub('.', '"."')}") | |||
There was a problem hiding this comment.
For consistency, how about moving the new gsub to quote_table_name?
rails/activerecord/lib/active_record/relation/query_methods.rb
Lines 1057 to 1058 in 6476651
gmcgibbon
force-pushed
the
sqlite_pluck_quoting
branch
from
4577bd7
to
93f1907
Compare
kamipo
added a commit
that referenced
this pull request
Dec 5, 2018
Fix join table column quoting with SQLite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34622.
Quotes joined columns properly in SQLite.