Fix examples in ActiveSupport::LogSubscriber docs #34835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
fix_examples_in_log_subscriber
branch
from
fc2cbfc
to
05b5dc9
Compare
| @@ -47,8 +47,8 @@ module ActiveSupport | |||
| # if exception | |||
| # exception_object = event.payload[:exception_object] | |||
| # | |||
| # "[ERROR] #{event.payload[:name]}: #{exception.join(', ')} " \ | |||
| # "(#{exception_object.backtrace.first})" | |||
| # info "[ERROR] #{event.payload[:name]}: #{exception.join(', ')} " \ | |||
There was a problem hiding this comment.
What about setting this example as error instead of info?
There was a problem hiding this comment.
Makes sense. I'll change it 👍
gmcgibbon
force-pushed
the
fix_examples_in_log_subscriber
branch
from
05b5dc9
to
1b402a5
Compare
xlts
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Thx @gmcgibbon, I totally missed that in my PR. Looks sweet now
albertoalmagro
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #34707, I noticed that the example subscribers in
ActiveSupport::LogSubscriberdon't actually log their output strings. This fixes that.