Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced webserver with web server #34997

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Replaced webserver with web server #34997

merged 1 commit into from
Jan 22, 2019

Conversation

alkesh26
Copy link
Contributor

No description provided.

gmcgibbon
gmcgibbon reviewed Jan 21, 2019
View reviewed changes
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be hesitant to call this a "typo" but I'm in favour of unifying our spelling in the docs, as I see it written both ways. Can you also change webserver_gemfile_entry to web_server_gemfile_entry here too?

@alkesh26
Copy link
Contributor Author

Sure @gmcgibbon. There is one more occurrence of webserver here replacing it.

@rails-bot rails-bot bot added the actionpack label Jan 22, 2019
@alkesh26 alkesh26 changed the title Web server typo fix. Replaced webserver with web server Jan 22, 2019
@eileencodes
Copy link
Member

@alassek can you squash your commits into 1? thanks!

@rafaelfranca
Copy link
Member

@eileencodes done!

@eileencodes eileencodes merged commit e26f065 into rails:master Jan 22, 2019
@alkesh26 alkesh26 deleted the typo-fix-webserver branch January 22, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcgibbon gmcgibbon gmcgibbon left review comments

Assignees
No one assigned
Labels
actionmailbox actionpack actiontext docs railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alkesh26 @eileencodes @rafaelfranca @gmcgibbon