Reword RDBMS note in ActiveRecord basics #35262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you are now a Rails committer I feel I need to correct your on this. When we talk about the framework we always separate the names, so Active Record. When we are talking about the constant the words are together and if you can with monospaced fonts, so |
| @@ -45,7 +45,7 @@ relationships of the objects in an application can be easily stored and | |||
| retrieved from a database without writing SQL statements directly and with less | |||
| overall database access code. | |||
|
|
|||
| NOTE: If you are not familiar enough with relational database management systems (RDBMS) or structured query language (SQL), please go through [this tutorial](https://www.w3schools.com/sql/default.asp) (or [this one](http://www.sqlcourse.com/)) or study them by other means. Understanding how relational databases work is crucial to understanding Active Records and Rails in general. | |||
| NOTE: A basic knowledge of relational database management systems (RDBMS) and structured query language (SQL) is helpful in order to fully understand ActiveRecord. Please refer to [this tutorial](https://www.w3schools.com/sql/default.asp) (or [this one](http://www.sqlcourse.com/)) or study them by other means if you would like to learn more. | |||
There was a problem hiding this comment.
Suggested change
| NOTE: A basic knowledge of relational database management systems (RDBMS) and structured query language (SQL) is helpful in order to fully understand ActiveRecord. Please refer to [this tutorial](https://www.w3schools.com/sql/default.asp) (or [this one](http://www.sqlcourse.com/)) or study them by other means if you would like to learn more. | |
| NOTE: Basic knowledge of relational database management systems (RDBMS) and structured query language (SQL) is helpful in order to fully understand ActiveRecord. Please refer to [this tutorial](https://www.w3schools.com/sql/default.asp) (or [this one](http://www.sqlcourse.com/)) or study them by other means if you would like to learn more. |
gmcgibbon
force-pushed
the
reword_ar_rdbms_note
branch
from
ceb6627
to
cbf1f69
Compare
gmcgibbon
force-pushed
the
reword_ar_rdbms_note
branch
from
cbf1f69
to
2987f34
Compare
|
Thanks @rafaelfranca, I'll keep that in mind writing docs going forward! |
rafaelfranca
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35260.
Rewords the RDBMS note in the ActiveRecord basics guide.
This may be an unpopular opinion, or promoting of bad behaviour, but I think a big advantage of ActiveRecord is that you don't actually need an intimate knowledge of SQL / RDBMS. Yes, they are helpful to know, and highly necessary in order to master ActiveRecord, but I wouldn't label them as crucial for beginners.