Show deprecated message instead of raise exception in compiled_method_container method
#35281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tenderlove |
|
I think it can break (or leak memory) in some cases, but I think you're right: it's better to emit a warning and continue to work than to raise an exception. Web console probably doesn't get reloaded, so there's probably no memory leak. Actually, maybe we should only emit the warning if self.class == AV::Base? |
…d_container` method Since rails#35036, the subclasses of `ActionView::Base` requires the `compiled_method_container`. This is incompatible. For example, `web-console` use view class that subclass of `ActionView::Base`, and does not work it now cause of this. Actually, since it seems that it is only `ActionView::Base` that `compiled_method_container` is necessary, modified the condition that emits a warning.
y-yagi
force-pushed
the
show_deprecated_message_instead_of_raise_exception
branch
from
2960d4f
to
7878027
Compare
I think that it makes sense because I couldn't come up with a case with an original view class other than debug view. I fixed condition and message. |
y-yagi
deleted the
show_deprecated_message_instead_of_raise_exception
branch
vipulnsward
added a commit
to vipulnsward/rails
that referenced
this pull request
Mar 12, 2019
…led container. Use the suggested with_empty_template_cache to overcome warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #35036, the subclasses of
ActionView::Baserequires thecompiled_method_containermethod.This is incompatible. For example,
web-consoleuse view class that subclass ofActionView::Base, and does not work it now cause of this.I am not sure that using
self.classis correct, but I think that it is better to show a deprecate message rather than raise exception.