New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update active_record_callbacks.md [ci skip] #35324
Conversation
Change 'happen' to a more technical term
@@ -340,7 +340,7 @@ end | |||
|
|||
### Combining Callback Conditions | |||
|
|||
When multiple conditions define whether or not a callback should happen, an `Array` can be used. Moreover, you can apply both `:if` and `:unless` to the same callback. | |||
When multiple conditions define whether or not a callback should execute, an `Array` can be used. Moreover, you can apply both `:if` and `:unless` to the same callback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also say 'run' instead of 'execute' as we've used on another line.
Thanks, both work better in different sentences. Can keep as is |
I don't think this should be merged. We already use "happen" a lots for callbacks and validations. rails/activemodel/lib/active_model/validations/absence.rb Lines 13 to 14 in b2eb1d1
rails/activemodel/lib/active_model/validations/presence.rb Lines 12 to 13 in b2eb1d1
rails/activerecord/lib/active_record/transactions.rb Lines 85 to 87 in 1cbc655
rails/guides/source/active_record_validations.md Lines 630 to 631 in 02e6abd
rails/guides/source/active_record_validations.md Lines 638 to 639 in 02e6abd
rails/guides/source/active_record_validations.md Lines 915 to 917 in 02e6abd
rails/guides/source/active_record_validations.md Lines 921 to 922 in 02e6abd
rails/guides/source/active_record_validations.md Lines 975 to 977 in 02e6abd
|
Reverted 30016df for now. |
This reverts commit 6b69ae5, reversing changes made to 84bd9ad. Reason: We already use "happen" a lots for callbacks and validations. #35324 (comment) [ci skip]
I see we use it for validations. For callbacks though, it just felt unnatural to read it that way, given its more referred to as "callback execution". Before merging, I tried searching if "callback happening" is a normal term to used anywhere, did not find many examples. Anyway happy to leave as is for now though. |
Change 'happen' to a more technical term