Add test for 'ActiveSupport::Inflector.transliterate' #35572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do these two methods need similar tests too? https://github.com/rails/rails/pull/35571/files#diff-9c7c8274426cb68629b863c3ddf57b2aR195 |
|
Let's add tests for those too, I think |
|
Saw your comment on the PR, I'll try to debug/fix it. |
Also add tests for parametrize and transliterate
sharang-d
force-pushed
the
tests-for-transliterate-locale-arg
branch
from
890349b
to
818437c
Compare
|
I've pushed the fix and new tests. I see that the original change does not have a changelog entry. Does it need one and should I add it? |
|
Doh! Yes, we should add a changelog entry too. |
|
I'll add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through #35571 and it looked like the change required specs so I added one.
cc @KaanOzkan, @rafaelfranca