Rename ActionView::Base#run
#35627
Merged
Rename ActionView::Base#run
#35627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebjacobs
changed the title
ActionView::Base#run to #callActionView::Base#run
sebjacobs
force-pushed
the
seb-rename-view-run-method
branch
from
fcb9f41
to
d4d5976
Compare
tenderlove
requested changes
Mar 15, 2019
That makes a lot more sense! cheers Aaron! |
There was a recent change by @tenderlove to Action view which introduced `ActionView::Base#run` [1]. We ran into an issue with our application because one of the core concepts in our domain model is a `Run` which is exposed in most of our views as a helper method, which now conflicts with this new method. Although this is a public method it is not really meant to be part of the public API. In order to discourage public use of this method and to reduce the chances of this method conflicting with helper methods we can prefix this method with an underscore, renaming this method to `_run`. [1] rails@c740ebdaf5
sebjacobs
force-pushed
the
seb-rename-view-run-method
branch
from
d4d5976
to
47fea39
Compare
|
@tenderlove I have fixed up this branch based on your feedback. Thanks for responding so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a recent change by @tenderlove to Action view which introduced
ActionView::Base#run[1].We ran into an issue with our application because one of the core concepts in our domain model is a
Runwhich is exposed in most of our views as a helper method also calledrun, which now conflicts with this new method.In order to save us having to rewrite a substantial part of our app I was wondering if we might be able to rename this method instead to something like
#callor perhaps#exec?[1] c740ebdaf5