Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ActionView::Base#run #35627

Merged
merged 1 commit into from
Mar 15, 2019

Commits on Mar 15, 2019

  1. Rename ActionView::Base#run to #_run

    There was a recent change by @tenderlove to Action view which introduced
    `ActionView::Base#run` [1].
    
    We ran into an issue with our application because one of the core
    concepts in our domain model is a `Run` which is exposed in most of our
    views as a helper method, which now conflicts with this new method.
    
    Although this is a public method it is not really meant to be part of
    the public API.
    
    In order to discourage public use of this method and to reduce the
    chances of this method conflicting with helper methods we can prefix
    this method with an underscore, renaming this method to `_run`.
    
    [1] rails@c740ebdaf5
    sebjacobs committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    47fea39 View commit details
    Browse the repository at this point in the history