New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aliases of `database` option in generators work #35679

Merged

y-yagi merged 1 commit into rails:master from y-yagi:make_aliases_of_database_option_work

Mar 20, 2019

Member

y-yagi commented Mar 20, 2019

Thor automatically adds - if aliases do not start with -.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53

But Thor follows a convention of one-dash-one-letter options. So, even if - is added to db, it does not work.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4

Follow up #34021.


          Make aliases of database option in generators work

e5d7b98

Thor automatically adds `-` if aliases do not start with `-`.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53

But Thor follows a convention of one-dash-one-letter options.
So, even if `-` is added to `db`, it does not work.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4

Follow up rails#34021.

rails-bot bot added activerecord railties labels

y-yagi merged commit ec72a9f into rails:master

y-yagi deleted the make_aliases_of_database_option_work branch

March 20, 2019 07:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment