Refactor Relation#cache_key is moved from CollectionCacheKey#collection_cache_key
#35848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
commented
Apr 4, 2019
| @@ -314,7 +314,50 @@ def many? | |||
| # overriding ActiveRecord::Base#collection_cache_key. | |||
There was a problem hiding this comment.
hmm... I've realized the doc now...
You can customize the strategy to generate the key on a per model basis overriding ActiveRecord::Base#collection_cache_key.
There was a problem hiding this comment.
Changed to just keep the expectation for now.
rafaelfranca
approved these changes
Apr 4, 2019
…ction_cache_key` The implementation of `Relation#cache_key` depends on some internal relation methods (e.g. `apply_join_dependency`, `build_subquery`), but somehow that implementation exists on the model class (`collection_cache_key`), it sometimes bothers to me. This refactors that implementation moves to `Relation#cache_key`, then we can avoid `send` to call internal methods.
kamipo
force-pushed
the
refactor_collection_cache_key
branch
from
6b96d9c
to
10919bf
Compare
kamipo
added a commit
that referenced
this pull request
Apr 19, 2019
The `collection_cache_key` is private API for a long time, but I've maintained it in #35848 since it is mentioned in the doc (#35848 (comment)). The doc has removed at 1da9a7e, so there is no longer a reason to maintain that private API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Relation#cache_keydepends on some internalrelation methods (e.g.
apply_join_dependency,build_subquery), butsomehow that implementation exists on the model class
(
collection_cache_key), it sometimes bothers to me.This refactors that implementation moves to
Relation#cache_key, thenwe can avoid
sendto call internal methods.