Refactor Relation#cache_key
is moved from CollectionCacheKey#collection_cache_key
#35848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Relation#cache_key
depends on some internalrelation methods (e.g.
apply_join_dependency
,build_subquery
), butsomehow that implementation exists on the model class
(
collection_cache_key
), it sometimes bothers to me.This refactors that implementation moves to
Relation#cache_key
, thenwe can avoid
send
to call internal methods.