Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-activerecord not respected on rails master due to actionmailbox and actiontext dependencies #36030

Closed
fables-tales opened this issue Apr 19, 2019 · 2 comments

Comments

@fables-tales
Copy link

Steps to reproduce

rails new --skip-active-record on master

Expected behavior

No activerecord dependency to be loaded, because config/database.yml isn't created, if an eventual dependency exists, an Could not load database configuration. No such file - [\"config/database.yml\"] is created.

System configuration

Rails version:
Master
Ruby version:
2.6

fables-tales pushed a commit to rspec/rspec-rails that referenced this issue Apr 19, 2019
@y-yagi
Copy link
Member

y-yagi commented Apr 19, 2019

A newly generated application does not load action_mailbox/engine and action_text/engine when specied --skip-activerecord option.

<%= comment_if :skip_action_mailbox %>require "action_mailbox/engine"
<%= comment_if :skip_action_text %>require "action_text/engine"

def skip_action_mailbox? # :doc:
options[:skip_action_mailbox] || skip_active_storage?
end
def skip_action_text? # :doc:
options[:skip_action_text] || skip_active_storage?
end

Is this reproduced with the newly created application, and can you get a trace of the error in that case?

@y-yagi y-yagi added the more-information-needed When reporter needs to provide more information label Apr 19, 2019
@fables-tales
Copy link
Author

this was due to RSpec weirdness.

@rails-bot rails-bot bot removed the more-information-needed When reporter needs to provide more information label Apr 19, 2019
fables-tales pushed a commit to rspec/rspec-rails that referenced this issue Apr 20, 2019
benoittgt pushed a commit to rspec/rspec-rails that referenced this issue May 1, 2019
fables-tales pushed a commit to rspec/rspec-rails that referenced this issue Jun 12, 2019
benoittgt pushed a commit to rspec/rspec-rails that referenced this issue Aug 21, 2019
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this issue Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants