document update_counters on relation [ci skip] #36073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Apr 24, 2019
gmcgibbon
reviewed
May 10, 2019
itsWill
force-pushed
the
document_update_counters_on_relation
branch
from
29daa6d
to
19eb85d
Compare
|
@gmcgibbon done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is related to: #36055 where someone would have benefitted from this method.
Since this commit by @kamipo the
update_countersis defined on theActiveRecord::Relation: 975fa15It seems that this is a useful feature outside of the internals as well, so having it documented in our public api seems like a good idea to me.
Other Information
Does the new
update_counterson the relation have to be added to theCHANGELOG?