[ci skip] Clarity about embed metadata in signed and encrypted cookie #36245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishaltelangre
changed the title
vipulnsward
reviewed
May 11, 2019
| @@ -85,7 +85,7 @@ Rails 6.1. You are encouraged to enable `config.force_ssl` to enforce HTTPS | |||
| connections throughout your application. If you need to exempt certain endpoints | |||
| from redirection, you can use `config.ssl_options` to configure that behavior. | |||
|
|
|||
| ### Purpose in signed or encrypted cookie is now embedded within cookies | |||
| ### Purpose metadata in signed or encrypted cookie is now embedded within cookies | |||
There was a problem hiding this comment.
The existing sentence is actually correct, though incomplete, the proposed change makes it sound even more wrong.
This should be:
Purpose and expiry metadata is now embedded inside signed and encrypted cookies for increased security.
There was a problem hiding this comment.
Yes, that's actually correct.
vishaltelangre
changed the title
vishaltelangre
commented
May 12, 2019
|
|
||
| To improve security, Rails embeds the purpose information in encrypted or signed cookies value. |
There was a problem hiding this comment.
This sentence seemed basically repeating the same thing as the new sub-heading.
There was a problem hiding this comment.
Lets retain this to maintain the flow of sentences below
There was a problem hiding this comment.
@vipulnsward Retained this sentence with some modifications made to it for consistency.
|
@vipulnsward Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purposeis not a known entity,purpose metadatais.