Fixes for Request#remote_ip (no middleware, all proxies) #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8d1a2b3, because I have fixed the issues this commit caused in the next commit.
tenderlove
added a commit
that referenced
this pull request
Nov 17, 2011
Fixes for Request#remote_ip (no middleware, all proxies)
|
👍 this makes me happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that the RemoteIp middleware might not be added to the stack. Hah. Also, when requesting directly from box with a proxy IP, we should return the IP, not filter it.
@jonleighton, this fixes all the test failures you noted from the previous merges.