Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Request#remote_ip (no middleware, all proxies) #3649

Merged
merged 3 commits into from Nov 17, 2011
Merged

Fixes for Request#remote_ip (no middleware, all proxies) #3649

merged 3 commits into from Nov 17, 2011

Commits on Nov 16, 2011

  1. Revert "Revert "Merge pull request rails#3640 from indirect/remote_ip"" 

    This reverts commit 8d1a2b3, because I have fixed the issues this commit caused in the next commit.
    @indirect
    indirect committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    f05ccf8 View commit details
    Browse the repository at this point in the history

  2. 🤦 Request#remote_ip has to work without the middleware

    @indirect
    indirect committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    5621abd View commit details
    Browse the repository at this point in the history

  3. the object itself isn't the IP, #to_s is the IP

    @indirect
    indirect committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    a9044d0 View commit details
    Browse the repository at this point in the history