Fixed db:prepare task to not touch schema when it is disabled #36744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
added a commit
that referenced
this pull request
Jul 24, 2019
Fixed db:prepare task to not touch schema when it is disabled
|
Thanks @morgoth! Backported to 6-0-stable 👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #36416 I forgot to move the conditional for dumping schema, that
is present in
rails/activerecord/lib/active_record/railties/databases.rake
Line 92 in 0e149ab
This is causing issues in environments with limited file permissions that are preparing database.
@eileencodes can we have it backported to 6-0-stable branch as well?