Added multiple database Active Record guide entry to the release notes #36823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaynikam
force-pushed
the
add-multiple-database-guide-entry-to-release-notes
branch
from
b7eb13e
to
4c7ba2c
Compare
|
This should go to the |
|
Oh. I didn't knew that. Let me fix it 😊 |
abhaynikam
force-pushed
the
add-multiple-database-guide-entry-to-release-notes
branch
from
4c7ba2c
to
5828aad
Compare
|
I am sorry about the labels, it happened because I changed the base to |
bogdanvlviv
reviewed
Aug 1, 2019
| @@ -1001,6 +1001,8 @@ Ruby on Rails Guides | |||
| Please refer to the [Changelog][guides] for detailed changes. | |||
|
|
|||
| ### Notable changes | |||
| * Add Multiple Databases with Active Record guide. | |||
There was a problem hiding this comment.
Can we add an empty line between "Notable changes" and this line for consistency with other sections?
abhaynikam
force-pushed
the
add-multiple-database-guide-entry-to-release-notes
branch
from
5828aad
to
0db87b9
Compare
eileencodes
added a commit
that referenced
this pull request
Aug 5, 2019
…-entry-to-release-notes Added multiple database Active Record guide entry to the release notes
abhaynikam
deleted the
add-multiple-database-guide-entry-to-release-notes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #36820 (comment)
Added the entry in the release notes for new guide.